LGTM On 27 June 2012 12:39, Hans Wennborg <[email protected]> wrote: > On Wed, Jun 27, 2012 at 3:30 PM, Rafael Espíndola > <[email protected]> wrote: >> On 26 June 2012 13:40, Hans Wennborg <[email protected]> wrote: >>> The attached patch adds support for the -ftls-model command-line flag. >>> Please take a look. >> >> There was some work at unifying Options.td and CC1Options.td. Do we >> have to change both? > > Ah, thanks for pointing that out. Seems like changing Options.td is enough. > > While investigating this, I stumbled across CodeGenOptions, which I > think might be a better fit for this flag than LangOptions, so moving > it there. > >> Why does >> >> llvm::GlobalVariable::ThreadLocalMode GetLLVMTLSModel(StringRef S) >> >> need DefaultCase? > > It doesn't. Removed. > >> Can you use a switch over Opts.getDefaultTLSModel in >> CompilerInvocation.cpp > > Done. > >> and a StringSwitch over the Model? > > Done. > > New patch attached. > > Thanks, > Hans
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
