On Jun 29, 2012, at 11:18 AM, Dmitri Gribenko <[email protected]> wrote:
> On Fri, Jun 29, 2012 at 11:15 AM, Douglas Gregor <[email protected]> wrote: >> On Jun 21, 2012, at 3:04 PM, Dmitri Gribenko <[email protected]> wrote: >>> Author: gribozavr >>> Date: Thu Jun 21 17:04:37 2012 >>> New Revision: 158940 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=158940&view=rev >>> Log: >>> Handle include directive with comments. It turns out that in this case >>> comments are not coming in source order. Instead of trying to std::sort() >>> comments (which can be costly), just remove comments that are not in order. >> >> Can we just fix the ordering of comments as produced by the lexer? > > I looked into that and I don't think it would be easy: preprocessor > wants to parse a complete directive before switching to another source > file. Can we just queue up the comment tokens when parsing the complete #include directive, so that the callbacks for them come after the #include is handled? - Doug _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
