Just to be clear, I discussed this with richard in person. I should have put my review comments on the mailing list, sorry for that. Don't want folks to think this went it without discussion first. It's my fault. =/
On Fri, Jun 29, 2012 at 2:15 PM, Richard Trieu <[email protected]> wrote: > On Thu, Jun 28, 2012 at 8:09 PM, Richard Trieu <[email protected]> wrote: > >> A few changes to template type diffing. Originally, the format was >> %diff{type is | not | }1,2 but this does not allow enough flexibility for >> diagnostic messages. The new format is %diff{type is $ not $ |see type >> tree}1,2. The text before the pipe is printed with a formatted type string >> replacing the $. If the tree is printed, the text after pipe is used. >> >> One set of diagnostics has been modified to use this. A test case has >> been added which also tests the change from r159386 (keeping bold on for >> non-notes). The internal manual has also been updated for this change. >> After this, a large scale change will be done to the diagnostic texts. >> > > Committed at r159463 so that the conversion of diagnostic messages can > move forward. > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
