On Jun 30, 2012, at 2:31 AM, Dmitri Gribenko wrote: > On Sat, Jun 30, 2012 at 12:55 AM, Enea Zaffanella > <[email protected]> wrote: >> In include/clang/AST/RawCommentList.h we have >> >> class RawComment { >> public: >> enum CommentKind { >> CK_Invalid, ///< Invalid comment >> [...] >> >> In include/clang/AST/OperationKinds.h the following macro is defined >> >> #define CK_Invalid ((CastKind) -1) > > Hi Enea, > > Thank you for noticing! > > Here is a patch that should fix this. > > Please review. > > Dmitri
It's possible the reason this isn't used is because CastKind would otherwise be only positive numbers and thus suitable for storing in an unsigned bitfield without complaint. Maybe ~0U would be a better choice of constant? Jordan _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
