On Jul 2, 2012, at 11:40 , Andy Gibbs <[email protected]> wrote:

> On Monday, July 02, 2012 7:46 PM, Jordan Rose wrote:
>> On Jun 30, 2012, at 2:12 PM, Andy Gibbs wrote:
>> 
>>> Part 3: Added extra diagnostic for invalid range in directive 
>>> <verify-part3.diff>
>> 
>> You should describe the new range syntax in the comment in 
>> VerifyDiagnosticConsumer.h, but otherwise LGTM.
> 
> Silly question: did you notice that I did describe the new syntax?  Is it 
> that you think I didn't explain it clearly enough?

Whoops, yes. I was expecting to see a line-of-code example for ranges just like 
for "x-or-more" syntax, in the spirit of "a picture is worth a thousand words". 
I just completely missed the single sentence that described the range syntax.

(The "…or more" description was fine.)


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to