A couple of things: * AttributedStmt::CreateEmpty isn't allocating enough space for the Attr*s. * Please capitalize the parameters to the AttributedStmt member functions.
LGTM with those fixed. On Fri, Jul 6, 2012 at 3:24 AM, Alexander Kornienko <[email protected]>wrote: > Did anyone have time to look at this? > > > On Thu, Jul 5, 2012 at 9:42 PM, Alexander Kornienko <[email protected]>wrote: > >> Hi, >> >> This patch changes AttrVec to inline storage of attributes in >> AttributedStmt. I also had to add a template parameter for container type >> to specific_attr_iterator to make it handle ArrayRef along with AttrVec. >> Updated serialization code, but there's still no good way to test it. >> >> Please take a look at this patch. >> >> -- >> Regards, >> Alexander Kornienko >> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
