On Wednesday, July 11, 2012 7:22 AM, Andy Gibbs wrote: > On Tuesday, July 10, 2012 11:41 PM, Jordan Rose wrote: >> On Jul 10, 2012, at 10:25 , Andy Gibbs wrote: >>> On Monday, July 02, 2012 11:15 PM, Jordan Rose wrote: >>>> [...snip...] >>>> StringRef :-) But I'm wondering now if this can share any code with >>>> Dmitri's >>>> doc-comment-parsing work, at least for \<EOL> folding. >>> >>> Changed to StringRef as suggested. I've had a look over the recent >>> changes >>> regarding comment parsing and I will consider moving over to this code >>> once >>> it has settled down a little (I note that revisions are still being made >>> to >>> it…). >> >> Fair enough. It might still be worth fast-pathing the case where there are >> no backslashes (to avoid an extra copy to stack). >> >> I'm only realizing now that ParseDirective should probably take a >> StringRef too. Can you clean that up while you're in there? >> >> Sorry to come up with new things to deal with, but that's the point of >> patch review, right? > > Well you ask so nicely, I can't but say I'll look into it...
Attached is that patch! Everything done now? :o) Cheers Andy
verify-part5.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
