You're right, we're going to find a better solution for our issue. I've removed this hook in r160432.
On Wed, Jul 18, 2012 at 12:28 AM, Douglas Gregor <[email protected]> wrote: > > On Jul 17, 2012, at 9:11 AM, Alexander Kornienko <[email protected]> > wrote: > > > Author: alexfh > > Date: Tue Jul 17 11:11:17 2012 > > New Revision: 160369 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=160369&view=rev > > Log: > > Add a custom initialize hook for clang tools + minor fixes in > CustomCompilationDatabase.h > > This kind of #define-based hack doesn't have a lot of precedent in Clang > or LLVM. What is the point of this custom initialization hook? Why does it > have to be a #define hacked into the build of Clang itself (which is > supposed to be a reusable *library*) rather than being introduced via a > plugin or by setting some function pointer/callback somewhere? > > This feels very much like the wrong solution for the problem you're trying > to solve, but it's not at all clear what problem you're solving. > > - Doug -- Best regards, Alexander Kornienko
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
