On Jul 18, 2012, at 5:39 AM, Alexander Kornienko <[email protected]> wrote:
> > On Tue, Jul 17, 2012 at 11:56 PM, Douglas Gregor <[email protected]> wrote: > > On Jul 17, 2012, at 7:47 AM, Alexander Kornienko <[email protected]> wrote: > > > This patch adds a custom initialize hook for clang tools. This is useful > > for plugging in custom initialization in private code bases and IDEs. > > Currently it can be used by compiling with a -DUSE_CUSTOM_TOOL_INIT and > > linking in an implementation for the customToolInit function. > > This kind of #define-based hack doesn't have a lot of precedent in Clang or > LLVM. What is the point of this custom initialization hook? Why does it have > to be a #define hacked into the build of Clang itself (which is supposed to > be a reusable *library*) rather than being introduced via a plugin or by > setting some function pointer/callback somewhere? > > This feels very much like the wrong solution for the problem you're trying to > solve, but you haven't actually told us what problem you're trying to solve. > > - Doug > You're right, we're going to find a better solution for our issue. I've > removed this hook in r160432. Great, thank you! - Doug
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
