Awesome work tracking this down. That is a strange practice. Are they all usually enums like this? If so, it should be possible to just add a sentinel value to the enumeration.
(btw, was valgrind not picking this up? or was it too infrequent for it to be worth running valgrind on every compilation?) --Sean Silva On Wed, Jul 18, 2012 at 3:55 PM, Robinson, Paul <[email protected]> wrote: > Guard use of a possibly uninitialized field. > > This was causing very unpredictable compiler crashes. I have not > provided a test because even our most reliable reproducer still failed > less than 10% of the time. > > I really really really don't like sometimes-uninitialized fields > guarded by flags. It is not a robust practice and took us a couple of > weeks of poking at it to find the root cause. But it is how the rest > of SemaOverload handles this field, so we fixed it using the > prevailing practice in the module. > --paulr > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
