Not sure who is responsible for the MS mangler, the LLVM code owner list doesn't list anyone directly responsible for non-codegen Windows stuff. It would be nice to see someone assigned to this task, at the moment the Windows patches take a lot of time to be reviewed or get forgotten on the list.
By the way, I don't think we need to enable blocks support in this test case. On Thu, Jul 19, 2012 at 11:29 AM, Timur Iskhodzhanov <[email protected]> wrote: > On Thu, Jul 19, 2012 at 2:28 PM, João Matos <[email protected]> wrote: >> Looks good to me. > Thanks! > > Can you please remind me if your review is enough to commit mangler changes? > >> On Wed, Jul 18, 2012 at 11:11 AM, Timur Iskhodzhanov >> <[email protected]> wrote: >>> Hi John, Charles, >>> >>> Can you please review this small MicrosoftMangle.cpp patch? >>> It fixes http://llvm.org/bugs/show_bug.cgi?id=13389 >>> and adds some tests. >>> >>> Thanks! >>> -- >>> Timur Iskhodzhanov, >>> Google Russia >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> >> >> >> >> -- >> João Matos -- João Matos _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
