On Jul 23, 2012, at 10:40 , Dmitri Gribenko <[email protected]> wrote:
> +bool Sema::isFunctionDecl() {
> + if (IsThisDeclInspected)
> + return IsFunctionDecl;
> +
> + inspectThisDecl();
> + return IsFunctionDecl;
> +}
> +
> +ArrayRef<const ParmVarDecl *> Sema::getParamVars() {
> + if (IsThisDeclInspected)
> + return ParamVars;
> +
> + inspectThisDecl();
> + return ParamVars;
> +}
My personal preference would be to have a single return here, since the body is
so short (just a call to the inspect… function).
if (!IsThisDeclInspected)
inspectThisDecl();
return ParamVars;
But more importantly, I don't see where IsThisDeclInspected gets reset to false.
Jordan
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
