On Jul 27, 2012, at 9:50 , jahanian <[email protected]> wrote: > > On Jul 27, 2012, at 9:35 AM, Jordan Rose wrote: > >> This commit was bothering me for a while, and I think I know why: >> >> - (id)getSpecialName:(CFDictionaryRef)dict { >> return [(NSDictionary *)dict objectForKey:MySpecialKey]; >> } >> >> - (voidd)extractSpecialName:(CFDictionaryRef)dict { >> _ivar = (id)CFDictionaryGetValue(dict, MySpecialCFKey); >> } >> >> Using CFBridgingRelease here would be very very wrong, in either case. > > This commit did not change the message on CFBridgingRelease. If it is wrong, > it was wrong before this > patch. Please file a new radar and provide the reasoning.
The commit removed the suggestion of __bridge, which would be the only correct thing to do here. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
