On Jul 27, 2012, at 4:27 PM, Jordan Rose wrote: > > On Jul 27, 2012, at 16:23 , jahanian <[email protected]> wrote: >>> >>> I wonder if leaving the "followsCreateRule" after the CFAuditedTransferAttr >>> check would be better; relying on the naming convention for un-audited code >>> may be a bad idea even >> >> If I leave it after, then CFAuditedTransferAttr check would not get me to >> check for the naming convention. Note that since in the non-diagnose case >> they both return >> ACC_invalid, this will not change the behavior. > > That's intentional. In our real headers, we have CFAuditedTransferAttrs on > all parts of CoreFoundation that are guaranteed to correctly follow the > naming conventions. CFDictionary.h, for example, is now bracketed in > _Pragma("clang arc_cf_code_audited begin") / _Pragma("clang > arc_cf_code_audited end"), which implicitly adds the attribute to everything > in between. We should probably have this in our fixit test cases. >
Should all be in r160902. - thanks, fariborz > Jordan
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
