On Mon, Jul 30, 2012 at 5:46 PM, Aaron Ballman <[email protected]>wrote:
> On Mon, Jul 30, 2012 at 8:31 PM, Chandler Carruth <[email protected]> > wrote: > > Why different code from the phases::Compile code right below that handles > > syntax only? I would expect these to be essentially identical. > > I will admit I'm not too familiar with the driver architecture, but > since this is applying to a header file, the phase comes in as > precompile and not compile. So I figured the special case was what > made sense, instead of moving C headers to compile phases. > Sorry, all I meant was to structure the code the same way. It would still be in the Precompile phase... > > > Your test doesn't need '-OPTIONS1' or any suffix -- you only have one > > compilation. > > > > Also, make sure your subversion client submits that new test file with > > native line endings rather than hard coded MS line endings. > > Fair points. If the fix is acceptable, I'll correct those on commit. > > ~Aaron >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
