Hey Michael, LGTM. It might be a bit cleaner to have isFlag() etc. type methods on the Option class instead of having client code check the kind directly.
- Daniel On Fri, Aug 17, 2012 at 4:47 PM, Michael Spencer <[email protected]> wrote: > The attached patch makes the clang::driver::Option class have no virtual > members. It also gets rid of all of its subclasses. The end goal of the > clang::driver::Option refactoring is to make it a value type that has a single > OptTable::Info* member. Each OptTable will return its own subclass of Option > that interprets the flag bits. > > - Michael Spencer _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
