Thanks, r162297.

Is there a reason why llvm::RoundUpToAlignment uses a divide and a
multiply, rather than an and? (Is it trying to handle non-power-of-two
alignments?)

On Tue, Aug 21, 2012 at 9:52 AM, Jakob Stoklund Olesen <[email protected]>wrote:

>
> On Aug 21, 2012, at 9:36 AM, Jordan Rose <[email protected]> wrote:
>
> >
> > On Aug 20, 2012, at 22:42 , Richard Smith <[email protected]>
> wrote:
> >
> >> +    ArrayIndexSize = (ArrayIndexSize + Align - 1) & ~(Align - 1);
> >
> > Yuck. Can we put this (and the other time in appears, during allocation)
> in a helper function in AlignOf.h?
>
> MathExtras.h already has RoundUpToAlignment().
>
> /jakob
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to