On Aug 13, 2012, at 12:08 AM, Daniel Jasper <[email protected]> wrote:
> Hi Doug,
>
> could you take a look at the patch? It mostly moves stuff around (putting the
> JSONCompilationDatabase into its own files) and implements the described
> design.
As noted on IRC, this looks great to me. Thanks!
- Doug
> Cheers,
> Daniel
>
>
> On Tue, Jul 31, 2012 at 7:54 AM, Douglas Gregor <[email protected]> wrote:
>
> On Jul 30, 2012, at 4:09 AM, Manuel Klimek <[email protected]> wrote:
>
> > On Mon, Jul 30, 2012 at 12:39 PM, Konstantin Tokarev <[email protected]>
> > wrote:
> >>
> >>
> >>> Hi Doug,
> >>>
> >>> any chance I could get this reviewed? I have another feature for the
> >>> compilation database (correctly handling relative directories) that I
> >>> would like to implement in the new structure.
> >>
> >> Sorry if I didn't understand something, but is there any real-world use
> >> case where these plugins are needed?
> >
> > We implemented it because we have a use case :) For example, we have a
> > server-based build system at Google that we want to query, where the
> > compilation database implementation depends on internal system
> > libraries that we cannot open source (mainly because it's not written
> > in a generic enough way). We have developers working in open source
> > land, and inside Google land, and we want to have one set of tools
> > that "just works".
>
> And Google is not alone in having their own in-house build systems that would
> benefit from such a plugin system.
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
