On Mon, Aug 27, 2012 at 3:04 PM, David Blaikie <[email protected]> wrote: > On Fri, Aug 24, 2012 at 10:43 PM, Richard Smith > <[email protected]> wrote: >> Author: rsmith >> Date: Sat Aug 25 00:43:00 2012 >> New Revision: 162642 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=162642&view=rev >> Log: >> Remove spurious string literal for bool argument. > > How'd you come across this? Compiler diagnostic or is it something > we're missing/could add?
-Wstring-conversion > >> >> Modified: >> cfe/trunk/lib/CodeGen/CGExprScalar.cpp >> >> Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=162642&r1=162641&r2=162642&view=diff >> ============================================================================== >> --- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original) >> +++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Sat Aug 25 00:43:00 2012 >> @@ -2123,7 +2123,7 @@ >> llvm::BasicBlock *Cont = CGF.createBasicBlock("shl.cont"); >> llvm::BasicBlock *Trap = CGF.getTrapBB(); >> llvm::Value *WidthMinusOne = >> - llvm::ConstantInt::get(RHS->getType(), Width - 1, "shl.width"); >> + llvm::ConstantInt::get(RHS->getType(), Width - 1); >> CGF.Builder.CreateCondBr(Builder.CreateICmpULE(RHS, WidthMinusOne), >> Cont, Trap); >> CGF.EmitBlock(Cont); >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
