On Aug 28, 2012, at 1:05 AM, John McCall wrote: > On Aug 27, 2012, at 2:28 PM, Chad Rosier wrote: >> Thanks, Matt! >> >> On Aug 27, 2012, at 2:15 PM, Matt Beaumont-Gay wrote: >> >>> Author: matthewbg >>> Date: Mon Aug 27 16:15:55 2012 >>> New Revision: 162700 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=162700&view=rev >>> Log: >>> Appease -Wnon-virtual-dtor >>> >>> Modified: >>> cfe/trunk/include/clang/AST/Stmt.h >>> >>> Modified: cfe/trunk/include/clang/AST/Stmt.h >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Stmt.h?rev=162700&r1=162699&r2=162700&view=diff >>> ============================================================================== >>> --- cfe/trunk/include/clang/AST/Stmt.h (original) >>> +++ cfe/trunk/include/clang/AST/Stmt.h Mon Aug 27 16:15:55 2012 >>> @@ -1393,6 +1393,8 @@ >>> explicit AsmStmt(StmtClass SC, EmptyShell Empty) : >>> Stmt(SC, Empty), Names(0), Exprs(0) { } >>> >>> + virtual ~AsmStmt() { } >>> + >>> SourceLocation getAsmLoc() const { return AsmLoc; } >>> void setAsmLoc(SourceLocation L) { AsmLoc = L; } > > Oh, whoa, I missed the commit which added a virtual table here. I'm not that > worried about the memory overhead of AsmStmt nodes, but making there be a > non-trivial this-adjustment between Stmt classes is an interesting wrench to > throw in. Is this essential?
Not essential. Committed r162768. Is that what you were looking for? Chad > John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
