On Aug 30, 2012, at 1:48 PM, Matt Beaumont-Gay <[email protected]> wrote:
> On Thu, Aug 30, 2012 at 12:26 PM, Ted Kremenek <[email protected]> wrote: >> --- cfe/trunk/include/clang/Frontend/CompilerInvocation.h (original) >> +++ cfe/trunk/include/clang/Frontend/CompilerInvocation.h Thu Aug 30 >> 14:26:38 2012 >> @@ -13,7 +13,7 @@ >> #include "clang/Basic/LangOptions.h" >> #include "clang/Basic/TargetOptions.h" >> #include "clang/Basic/FileSystemOptions.h" >> -#include "clang/Frontend/AnalyzerOptions.h" >> +#include "clang/StaticAnalyzer/AnalyzerOptions.h" > > Hi Ted, > > This introduces a cyclic dependency between StaticAnalyzer and > Frontend (lib/StaticAnalyzer/Frontend/FrontendActions.cpp includes > "clang/Frontend/CompilerInstance.h"). Can we factor these headers to > fix the cycle? > > -Matt Hi Matt, I don't see how this introduces that dependency. Wasn't it there already? AnalyzerOptions.h does not include anything from clang/Frontend. I didn't change any of the other headers. I'm not contesting that there is a cyclic dependency; I just don't see how I introduced one. Ted _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
