On Tue, Sep 4, 2012 at 9:23 AM, Alexander Kornienko <[email protected]>wrote:
> > > On Tue, Sep 4, 2012 at 5:05 PM, Nico Weber <[email protected]> wrote: > >> On Tue, Sep 4, 2012 at 8:01 AM, Alexander Kornienko <[email protected]>wrote: >> >>> >>> >>> On Tue, Sep 4, 2012 at 4:38 PM, Nico Weber <[email protected]> wrote: >>> >>>> ... >>>> Remove. >>>> >>>> >>>>> + let l:output = system(a:cmd) >>>>> + cexpr l:output >>>>> + cwindow >>>>> >>>> + let w:quickfix_title = a:cmd >>>>> + if v:shell_error != 0 >>>>> + cc >>>>> + endif >>>>> >>>> >>>> Replace all that with >>>> >>>> let l:oldmakepgr = &makeprg >>>> let &makeprg = a:cmd >>>> silent make | cwindow >>>> let &makeprg = l:oldmakepgr >>>> >>>> (Gives you a warning when trying to compile a modified buffer too) >>>> >>> Doesn't work for me: after running your code vim (7.3, if this matters) >>> doesn't repaint it's window, and I end up having a blank screen until I >>> make vim repaint everything. >> >> >> If you don't use gvim, you might need a >> >> if !has('gui') redraw! endif >> > 1. Have you tried to use your snippet? > 2. If yes, what version of vim do you use? > Yes, it's what we use in some vim helper script some chromium folks use. I use it with 7.3. ( http://git.chromium.org/gitweb/?p=chromium/src.git;a=blob;f=tools/vim/ninja-build.vim#l80) > As for this line, my vim understands it only after I add delimiters: if > !has('gui') | redraw! | endif > But the problem is not with it, it's with :make also not giving a warning > when trying to compile a modified buffer. And even if it did complain about > _current_ buffer being modified, we probably need it to display warning > _any_ buffer is modified (it's the most consistent way to avoid stale files > being compiled, I think). > > So, currently, I don't see any advantages of your version. > It has the advantage that it does the things documented at `:help :make`. It's also a bit shorter. > > >> too. >> >> >>> >>> >>> >>> -- >>> Regards, >>> Alex >>> >> >> > > > -- > Alexander Kornienko | Software Engineer | [email protected] | +49 151 221 > 77 957 > Google Germany GmbH | Dienerstr. 12 | 80331 München > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
