Author: alexfh Date: Mon Sep 10 09:54:38 2012 New Revision: 163513 URL: http://llvm.org/viewvc/llvm-project?rev=163513&view=rev Log: Workaround for MacOSX build failure with gcc <= 4.4
Summary: A better solution to http://llvm.org/bugs/show_bug.cgi?id=13777 Named namespace + more unique name to make ODR violations unlikely. Reviewers: chandlerc, doug.gregor, klimek Reviewed By: doug.gregor CC: cfe-commits Differential Revision: http://llvm-reviews.chandlerc.com/D38 Modified: cfe/trunk/tools/clang-check/ClangCheck.cpp Modified: cfe/trunk/tools/clang-check/ClangCheck.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/ClangCheck.cpp?rev=163513&r1=163512&r2=163513&view=diff ============================================================================== --- cfe/trunk/tools/clang-check/ClangCheck.cpp (original) +++ cfe/trunk/tools/clang-check/ClangCheck.cpp Mon Sep 10 09:54:38 2012 @@ -58,10 +58,10 @@ "ast-dump-filter", cl::desc(Options->getOptionHelpText(options::OPT_ast_dump_filter))); -// Anonymous namespace here causes problems with gcc <= 4.4 on MacOS: -// http://llvm.org/bugs/show_bug.cgi?id=13777 -// namespace { -class ActionFactory { +// Anonymous namespace here causes problems with gcc <= 4.4 on MacOS 10.6. +// "Non-global symbol: ... can't be a weak_definition" +namespace clang_check { +class ClangCheckActionFactory { public: clang::ASTConsumer *newASTConsumer() { if (ASTList) @@ -73,10 +73,10 @@ return new clang::ASTConsumer(); } }; -// } +} int main(int argc, const char **argv) { - ActionFactory Factory; + clang_check::ClangCheckActionFactory Factory; CommonOptionsParser OptionsParser(argc, argv); ClangTool Tool(OptionsParser.GetCompilations(), OptionsParser.GetSourcePathList()); _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
