Hi guys, I don't think we want to add this functionality into the codebase via configure/cmake. At best I think these should be local files that can be patched by the individual vendors - a small patch to a couple of files is likely to be the least of the work of creating a product. I'm open to ways to make that part of the job easier though.
-eric On Aug 28, 2012, at 3:22 PM, Sebastian Pop <[email protected]> wrote: > Hi Ron, > > the two patches look good to me. I would like Eric or somebody > else to also have a look and approve the patches. > > Thanks, > Sebastian > > On Mon, Aug 27, 2012 at 3:15 PM, ronl <[email protected]> wrote: >> And here are the two patches J >> >> >> >> >> >> From: [email protected] >> [mailto:[email protected]] On Behalf Of ronl >> Sent: Monday, August 27, 2012 3:13 PM >> To: [email protected]; [email protected] >> Subject: [cfe-commits] revised: [PATCH] Add configuration of CLANG_VENDOR, >> VENDOR_GCC_VERSION >> >> >> >> Please find attached two revised patches for Add configuration of >> CLANG_VENDOR, VENDOR_GCC_VERSION. >> >> Removes the extraneous braces {} from an if statement. >> >> Removed extraneous space from a comment in the file configure.ac. >> >> >> >> >> >> Note: >> >> Two patches associated with this commit, first for llvm, second for clang. >> >> The clang patch >> >> 0002-Add-configuration-of-CLANG_VENDOR-VENDOR_GCC_VERSION.patch >> >> depends on the llvm patch >> >> 0001-Add-configuration-of-CLANG_VENDOR-VENDOR_GCC_VERSION.patch >> >> >> >> Defaults for the new configure options: >> >> --with-vendor-gcc-version defaults to.4.2.1. >> >> --with-clang-vendor defaults to null. >> >> >> >> The -v and --version command line options will print the version # last, >> >> after the thread model and target. >> >> >> >> -v will no longer produce unused command line argument warnings. This was >> >> for GCC comparability, which prints the version number last, and suppresses >> >> unused option warnings. >> >> >> >> The vendor name, and version are configured via the following options to >> >> configure \ >> >> --with-clang-vendor="QuIC LLVM Hexagon 6.1-pre-BT_201208240506 " \ >> >> --with-vendor-gcc-version="6.0.00" \ >> >> >> >> Examples: >> >> >> >> $ clang -v -Wall |& tail -1 >> >> QuIC LLVM Hexagon 6.1-pre-BT_201208240506 clang version 3.2 (clang >> <repo_url> <ID>) (llvm <repo_url> <ID>) >> >> >> >> $ clang -v >> >> Target: hexagon-unknown-linux-gnu >> >> Thread model: posix >> >> QuIC LLVM Hexagon 6.1-pre-BT_201208240506 clang version 3.2 (clang >> <repo_url> <ID>) (llvm <repo_url> <ID>) >> >> >> >> $ clang -dumpversion >> >> 6.0.03 >> >> >> >> $ clang --version >> >> Target: hexagon-unknown-linux-gnu >> >> Thread model: posix >> >> QuIC LLVM Hexagon 6.1-pre-BT_201208240506 clang version 3.2 (clang >> <repo_url> <ID>) (llvm <repo_url> <ID>) >> >> >> >> Hexagon Clang defined __VERSION__ >> >> __VERSION__ "4.2.1 Compatible QuIC LLVM Hexagon 6.1-pre-BT_201208240506 >> Clang 3.2 (clang <repo_url> <ID>) (llvm <repo_url> <ID>) >> >> >> >> Testing: >> >> cmake >> >> cmake -DCLANG_VENDOR_GCC_VERSION= >> >> cmake -DCLANG_VENDOR= >> >> cmake -DCLANG_VENDOR_GCC_VERSION= -DCLANG_VENDOR= >> >> cmake -DCLANG_VENDOR_GCC_VERSION=6.0.03 >> >> cmake -DCLANG_VENDOR="QuIC LLVM Hexagon 6.1-pre-BT_201208240506" >> >> cmake -DCLANG_VENDOR_GCC_VERSION=6.0.03 -DCLANG_VENDOR="QuIC LLVM Hexagon >> 6.1-pre-BT_201208240506" >> >> >> >> configure >> >> configure --with-vendor-gcc-version= >> >> configure --with-vendor-gcc-version=6.0.03 >> >> configure --with-clang-vendor= >> >> configure --with-clang-vendor= --with-vendor-gcc-version= >> >> configure --with-clang-vendor="QuIC LLVM Hexagon 6.1-pre-BT_201208240506 " >> >> configure --with-vendor-gcc-version=6.0.03 --with-clang-vendor="QuIC LLVM >> Hexagon 6.1-pre-BT_201208240506 " >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > > > -- > Qualcomm Innovation Center, Inc is a member of Code Aurora Forum _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
