On Sep 12, 2012, at 3:51 AM, r4start wrote:
> This patch is fix for this bug http://llvm.org/bugs/show_bug.cgi?id=13761.

+  static bool NeedThisReturn(GlobalDecl GD);

Please name this 'needsThisReturn'.

Also, please leave the FIXMEs about "is base" in place;  those are still
applicable (the flag is passed to constructors and destructors of classes
with virtual bases).

Otherwise this looks fine.  I can't remember if you can commit.

John.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to