On Sep 12, 2012, at 4:24 AM, Richard Smith wrote: > On Wed, Sep 12, 2012 at 2:08 AM, Andy Gibbs <[email protected]> wrote: > Hi, > > Attached are two patches to complement the recent work done by David Robins > on __interface. > > The first, interface-fix.diff, corrects a codegen regression created by > r163013 whereby all methods (including constructors) inside an __interface > were being marked pure virtual and were causing the vtable generation to be > invalid. > > Applying this to operators doesn't seem correct, since an __interface > shouldn't have any operators in the first place. Also, getOverloadedOperator > doesn't check for conversion operators.
Presumably it gets the implicit copy/move assignment operators, which should definitely not be virtual. Oh, and could someone check whether __interface implicitly declares a virtual destructor? That seems like a possibility. John.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
