On Sep 12, 2012, at 5:02 PM, John McCall wrote: > On Sep 12, 2012, at 1:34 PM, Fariborz Jahanian wrote: >> >> @@ -335,7 +337,7 @@ >> Param->setInvalidDecl(); >> if (!Param->isInvalidDecl() && >> getLangOpts().ObjCAutoRefCount && >> - !StrongPointerToObjCPointer(*this, Param)) >> + !HasExplicitOwnershipAttr(*this, Param)) >> Diag(Param->getLocation(), diag::warn_arc_strong_pointer_objc_pointer) >> << >> Param->getType(); > > Why is this code in SemaDeclObjC anyway? Shouldn't it be in the code in > SemaType where we add the implicit ownership qualification?
I put it there for convenience as we issue other diagnostics in the same area. I will move it to SemaType (it also simplifies logic for HasExplicitOwnershipAttr a little). - Thanks, Fariborz > > John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
