On Sep 17, 2012, at 3:38 PM, Richard Smith wrote: > On Mon, Sep 17, 2012 at 12:15 PM, Fariborz Jahanian <[email protected]> > wrote: > Author: fjahanian > Date: Mon Sep 17 14:15:26 2012 > New Revision: 164047 > > URL: http://llvm.org/viewvc/llvm-project?rev=164047&view=rev > Log: > objective-C: issue warning when there is no whitespace > between objc method parameter name and colon. > // rdar://12263549 > > Added: > cfe/trunk/test/SemaObjC/warning-missing-selector-name.m > Modified: > cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td > cfe/trunk/lib/Parse/ParseObjc.cpp > cfe/trunk/test/SemaObjC/unused.m > > Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=164047&r1=164046&r2=164047&view=diff > ============================================================================== > --- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original) > +++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Mon Sep 17 14:15:26 > 2012 > @@ -213,6 +213,12 @@ > "expected ';' after static_assert">; > def err_expected_semi_for : Error<"expected ';' in 'for' statement > specifier">; > def err_expected_colon_after : Error<"expected ':' after %0">; > +def missing_selector_name : Warning< > + "parameter name used as selector" > + " may result in incomplete method selector name">, > + InGroup<DiagGroup<"missing-argument-name-in-selector">>; > > You're missing the "warn_" from this warning name.
Yes thanks, I am coming up with a new patch. - Fariborz
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
