I left it because of the FIXMEs which I didn't know anything about. I'll remove it tonight.
On Tue, Sep 18, 2012 at 5:33 PM, Richard Smith <[email protected]>wrote: > On Tue, Sep 18, 2012 at 3:45 PM, Matthieu Monrocq < > [email protected]> wrote: > >> >> >> On Tue, Sep 18, 2012 at 2:30 AM, Craig Topper <[email protected]>wrote: >> >>> Author: ctopper >>> Date: Tue Sep 18 00:30:57 2012 >>> New Revision: 164104 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=164104&view=rev >>> Log: >>> Remove an unused private field exposed by the recent >>> LLVM_DELETED_FUNCTION changes. >>> >>> Modified: >>> cfe/trunk/include/clang/Sema/TemplateDeduction.h >>> >>> Modified: cfe/trunk/include/clang/Sema/TemplateDeduction.h >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/TemplateDeduction.h?rev=164104&r1=164103&r2=164104&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/include/clang/Sema/TemplateDeduction.h (original) >>> +++ cfe/trunk/include/clang/Sema/TemplateDeduction.h Tue Sep 18 00:30:57 >>> 2012 >>> @@ -28,9 +28,6 @@ >>> /// deduction, whose success or failure was described by a >>> /// TemplateDeductionResult value. >>> class TemplateDeductionInfo { >>> - /// \brief The context in which the template arguments are stored. >>> - ASTContext &Context; >>> - >>> /// \brief The deduced template argument list. >>> /// >>> TemplateArgumentList *Deduced; >>> @@ -51,7 +48,7 @@ >>> >>> public: >>> TemplateDeductionInfo(ASTContext &Context, SourceLocation Loc) >>> - : Context(Context), Deduced(0), Loc(Loc), >>> HasSFINAEDiagnostic(false) { } >>> + : Deduced(0), Loc(Loc), HasSFINAEDiagnostic(false) { } >>> >>> Looks to me like Context now is an unused argument. >> > > Also the FIXMEs referring to the removed variable should be removed. They > don't seem to be marking something worth fixing any more. > -- ~Craig
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
