The first patch had already been committed. Instead of XFAILing the second test on ARM, I added a target triple to ensure that the type of wchar_t is fixed rather than varying by platform. Committed in r164315.
On Thu, Sep 20, 2012 at 12:53 AM, 陳韋任 (Wei-Ren Chen) <[email protected]> wrote: > Ping? > > On Mon, Sep 17, 2012 at 10:05:22AM +0100, David Tweed wrote: >> Hi, >> >> | This is continuing work on make clang tests pass on ARM. The first >> | patch, compound-literals.cpp.patch, is fixed to consider ARM C++ ABI, >> | more details can be found in [1]. The second one, p2.cpp.patch, is >> | marked as XFAIL since the assumption about this test case is not right >> | on ARM, this is the test case's flaw as be discussed in [2]. >> >> I've had a look over these two patches and they both look good to me. >> >> Cheers, >> David Tweed >> >> > > -- > Wei-Ren Chen (陳韋任) > Computer Systems Lab, Institute of Information Science, > Academia Sinica, Taiwan (R.O.C.) > Tel:886-2-2788-3799 #1667 > Homepage: http://people.cs.nctu.edu.tw/~chenwj > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
