Other than these style nits, it looks good. Manuel, any more comments or
should I submit?
================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:818
@@ +817,3 @@
+ EXPECT_TRUE(notMatches("void f() { for (int i; i<5; ++i); }",
+ forRangeStmt()));
+}
----------------
Fix indent.
================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2004
@@ +2003,3 @@
+ EXPECT_TRUE(notMatches("#include <initializer_list>\n"
+ "void f() { for (auto &a : {1, 2, 3}); }",
+ forStmt()));
----------------
Fix indent.
================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2132
@@ -2103,1 +2131,3 @@
+ EXPECT_TRUE(matchesConditionally(
+ "namespace std { typedef typeof(sizeof(int)) size_t; }"
"class X { void *operator new(std::size_t); };",
----------------
Fix indent (be consistent with the one below), which looks better.
http://llvm-reviews.chandlerc.com/D46
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
