LGTM.

But I would suggest that re-use the CHECK-ANDROID, CHECK-ANDROID-SO,
CHECK-ANDROID-STATIC, and CHECK-ANDROID_PIE in linux-ld.c (Check the
attached patch for details)

Sincerely,
Logan

On Tue, Oct 2, 2012 at 6:00 AM, Simon Atanasyan <[email protected]> wrote:

> On Sun, Sep 30, 2012 at 11:42 PM, Simon Atanasyan <[email protected]>
> wrote:
> >
> > On Sat, Sep 29, 2012 at 12:04 AM, Simon Atanasyan <[email protected]>
> wrote:
> >> The patch adds "mipsel-linux-android" to the list of valid MIPS target
> >> triples. That simplifies usage of clang with Android NDK.
> >
> > Here is the second version of the patch. Now Clang driver constructs a
> > correct path to crt*.o object files if target is mipsel-linux-android
> > and arcitecture/CPU is MIPSr2.
> >
> > Please review the patch.
>
> Ping.
>
> --
> Simon
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

Attachment: mips-android-3.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to