On Wed, 03 Oct 2012 07:10:53 -0500 "William J. Schmidt" <[email protected]> wrote:
> Here's a revised version that tightens things up a bit with better use > of inheritance. Thanks for working on this! Question about your comment: > + // TODO: Could override computeInfo to model the ABI more > completely if > + // it would be helpful. Example: We might remove the byVal flag > from > + // aggregate arguments that fit in a register to avoid pushing > them to > + // memory on function entry. It seems to me that you're the foremost expert on whether or not this would be helpful ;) -- so would it? If these things are optimizations, then say so; if they're required for full ABI compliance, then note that explicitly. Otherwise, LGTM. -Hal > > Thanks, > Bill > -- Hal Finkel Postdoctoral Appointee Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
