Will try. From: Chris Lattner [mailto:[email protected]] Sent: Thursday, October 04, 2012 1:42 PM To: Kim Gräsman Cc: Villmow, Micah; Evan Cheng; [email protected] LLVM; [email protected] cfe; Nadav Rotem Subject: Re: [cfe-commits] [llvm-commits] [Patch] Move TargetData from Target to Support/VMCore
On Oct 4, 2012, at 1:32 PM, Kim Gräsman <[email protected]<mailto:[email protected]>> wrote: HI Micah, On Thursday, October 4, 2012, Villmow, Micah wrote: Chris, the problem with steps #2/#3 is that plenty of clients have forward declarations of TargetData and the typedef won't work in this case, so I need to update the clients anyways. One trick I've used as an alternative to typedefs is to just derive from the old class, e.g. class NewName : public TargetData {}; This is forward-declarable just as well as TargetData itself. Good idea. Micah, your first patch looks good to me, please commit. Can you use the subclass trick to make the next ones incremental like we discussed? -Chris
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
