I moved the enum warning check into pragma-ms_struct.c and moved the new 
mms-bitfields-1.c test file into the Sema directory, distilling the tests down.

Jeremiah

-----Original Message-----
From: Eli Friedman [mailto:[email protected]]
Sent: Tuesday, October 09, 2012 6:41 PM
To: Jeremiah Zanin
Cc: [email protected]
Subject: Re: [cfe-commits] Fix for the -mms-bitfields commandline parameter

On Tue, Oct 9, 2012 at 8:53 AM, Jeremiah Zanin 
<[email protected]> wrote:
> Ok, here's the updated patch.

+/// isMsStrust - Get whether or not this is an ms_struct which can ///
+be turned on with an attribute, pragma, or -mms-bitfields ///
+commandline option.

/// isMsStruct - Get whether or not this record uses ms_struct layout.
/// This which can be turned on with an attribute, pragma, or the /// 
-mms-bitfields command-line option.


There are some existing tests in test/Sema/pragma-ms_struct.c ; please move the 
tests which don't depend on the -mms-bitfields flag there, and add a test next 
to it to test -mms-bitfields.  The current "test/CodeGen/mms-bitfields.c" is 
not a good example to follow.

-Eli

________________________________

This message, including any attachments, may contain privileged and/or 
confidential information. Any distribution or use of this email by anyone other 
than the intended recipient(s) is strictly prohibited. If you are not the 
intended recipient, please notify the sender immediately and delete all copies. 
Thank you.

Attachment: mms-bitfields.patch
Description: mms-bitfields.patch

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to