On Oct 9, 2012, at 8:53 PM, Chris Lattner <[email protected]> wrote: > > On Oct 8, 2012, at 9:10 AM, Sean Silva <[email protected]> wrote: > >> This patch set removes the last traces of RTTI from TableGen (both in >> LLVM and Clang) and removes the crutch for enabling RTTI when building >> it. > > This all sounds fine to me, if it's ok with Jakob, go for it!
LGTM with these minor changes: - The 'kind' enums should be protected, not public. - The enumerator naming should follow the style guide. - Don't use funky indentation in the enums. /jakob _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
