I don't know enough about this to make good comments, but rather than have "isMultiplex" as the field in Sema, why not call it "isOwned"? That's more in line with some of our other delegate-pattern uses, and it keeps it from being a temptation to start abusing the field. We could also some day in the future allow Sema to take ownership of arbitrary external sources as well, though that's clearly not a goal right now.
Probably you should wait for Doug or someone to review this before committing. Jordan On Oct 11, 2012, at 8:02 , Vassil Vassilev <[email protected]> wrote: > Hi, > We need to attach multiple ExternalSources to Sema, to provide modules /and/ > last resort lookup. Right now that's a pain. The attached patch makes this > much easier, at (almost?) no runtime cost for the compiler. Okay to commit? > Vassil > <llvm-tools-clang-MultiplexExternalSemaSource.diff>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
