On Thu, Oct 11, 2012 at 9:50 AM, Grzegorz Jablonski <[email protected]> wrote: > On 10/10/2012 01:42 AM, Eli Friedman wrote: >> >> On Tue, Oct 9, 2012 at 8:56 AM, Grzegorz Jablonski <[email protected]> >> wrote: >>> >>> Hello, >>> >>> I have made a few patches fixing some cases from bug 11806. Please review >>> them. I attach also the testcases for them. >> >> Please attach one patch per email; please include automated testcases >> to be added to clang/test/ within each patch. >> >> > I have sent it already, but it went to the wrong thread. Do the attachements > contain what you expect?
By "one patch per email", I meant send in the changes one at a time, not collapse them into a single patch. The use of FileCheck looks fine. Please include testcases as part of each patch (svn diff will show new files added with svn add). Also, all the tests should eventually end up in a single file in the regression tests. -Eli _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
