On Oct 18, 2012, at 1:48 PM, David Blaikie <[email protected]> wrote:
> On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor <[email protected]> wrote: >> >> On Oct 18, 2012, at 9:57 AM, David Blaikie <[email protected]> wrote: >> >>> Author: dblaikie >>> Date: Thu Oct 18 11:57:32 2012 >>> New Revision: 166188 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=166188&view=rev >>> Log: >>> PR14021: Copy lookup results to ensure safe iteration. >>> >>> Within the body of the loop the underlying map may be modified via >>> >>> Sema::AddOverloadCandidate >>> -> Sema::CompareReferenceRelationship >>> -> Sema::RequireCompleteType >>> >>> to avoid the use of invalid iterators the sequence is copied first. >> >> Did you audit other uses of LookupConstructors to ensure that this is the >> only ticking time bomb in this area? > > [+Robert Muth] > > I've not performed any such audit, no. With the hack debug check > inserted we could just run the whole test suite to see if anything > pops up. That seems unlikely to help; this is only a problem when the underlying StoredDeclsList has to reallocate. - Doug _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
