On Oct 18, 2012, at 2:58 PM, Douglas Gregor <[email protected]> wrote:
> > On Oct 18, 2012, at 2:52 PM, Eric Christopher <[email protected]> wrote: > >> Author: echristo >> Date: Thu Oct 18 16:52:18 2012 >> New Revision: 166236 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=166236&view=rev >> Log: >> Add a new option for and disable column number information as there >> are no known current users of column info. Robustify and fix up >> a few tests in the process. Reduces the size of debug information >> by a small amount. > > > I'd rather we try to optimize column-number computation first. If we can make > it fast enough, we don't need to add this tweaking flag. Did you take a look at the comments in the PR? There is no known client of this information, it bloats debug information, and it forces computation (which, yes, could be sped up) that isn't otherwise needed. It seems like clearly the wrong thing to enable by default. When/if we want to enable it by default, it can be carefully measured and other options can be considered (maybe subexpression range info, not just line/col info, etc). -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
