On Thu, Oct 18, 2012 at 4:21 PM, Craig Topper <craig.top...@gmail.com> wrote: > Gating the code doesn't actually hide the perf problem. Because the perf > problem occurs in getPresumedLoc which calculates line and column number. > The debug code was calling getPresumedLoc twice once to only get the line > and once to only get the column, but this results in line and column > actually being calculated twice. > > Perhaps the debug code should be refactored to only call getPresumedLoc > once? >
Can do that too. That said your patch is pretty useful as well :) There are more uses for the column number than just debug info. -eric _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
