Yeah. I realize the text of the warning wasn't super. I'm rethinking the whole
patch though. As it turns out, people write bad ASM all the time, like
asm("foo %0", "=r" :);
I don't know if it's profitable to warn in this situation or the like.
-bw
On Oct 24, 2012, at 6:50 PM, John McCall <[email protected]> wrote:
> On Oct 24, 2012, at 5:32 PM, Bill Wendling wrote:
>> Author: void
>> Date: Wed Oct 24 19:32:44 2012
>> New Revision: 166655
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=166655&view=rev
>> Log:
>> Revert r166647 to rethink the patch...
>
> FWIW, Eli's review just means that you shouldn't ever add a warning
> without putting it in a warning group. But in general, please don't
> speculatively add warnings that you don't intend to support; the
> diagnostic text here is worryingly wishy-washy.
>
> John.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
