On Fri, Oct 26, 2012 at 11:14 PM, Mahesha HS <[email protected]> wrote: > Hi Dmitri, > > Thanks for the review. I have taken care of all your comments. With > respect to the use of std::lower_bound() instead of our own binary > search implementation, looks like, it is *not* straightforward as the > search algorithm actually need to operate on a map table which holds > the pair <StringRef, Enum Type>. However, I will re-think about it and > modify it if it is possible in some way. > > I will be committing first three patches as most of the review > comments are taken care for them. I will cross verify and make sure > that these patches will *strictly* adhere to CLANG/LLVM coding > standard before committing.
I'm really sorry, but that is *not* the policy of pre-commit review, or commit access after *approval*. Please wait until you get explicit approval, especially for such very large feature additions to Clang. Reviewers often focus on one set of issues for a particular round of review and may have further issues they need you to address before committing. -Chandler _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
