Landed in r166893, thanks! (With a slightly tweaked test: Since yours used an unknown namespace, it failed to reproduce the crash even without your patch.)
On Fri, Oct 26, 2012 at 11:39 PM, Brian Brooks <[email protected]> wrote: > Updated patch with test case added. Thanks for catching that! > > > On Sat, Oct 27, 2012 at 1:16 AM, Nico Weber <[email protected]> wrote: >> >> Thanks for the patch! >> >> Instead of adding a bool, can you just check if Ident is not 0? Also, >> can you please add a test case? You can add the whole test suite with >> `make test` and an individual test e.g. like `../../utils/lit/lit.py >> -v test/Parser/cxx-member-crash.cpp`. Maybe you can just create >> test/Parser/cxx-crash.cpp which can become a collection of parser >> crash tests. >> >> Nico >> >> On Fri, Oct 26, 2012 at 10:07 PM, Brian Brooks <[email protected]> >> wrote: >> > Attached is a patch for the following bug: >> > >> > http://llvm.org/bugs/show_bug.cgi?id=14085 >> > >> > >> > _______________________________________________ >> > cfe-commits mailing list >> > [email protected] >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
