FWIW, I continue to think we should fix the attribute design first before spreading its use throughout LLVM and Clang. I'm not going to review any patches spreading its use until we get the design right, as I don't have any rational basis on which to evaluate them given a flawed design.
It seemed like there was no real disagreement about what the right long-term design is, and so I'm confused why we aren't just making that so, and are instead spending reviewer time (and your time!) on a path that we will eventually reverse. On Mon, Oct 29, 2012 at 11:39 AM, Quentin Colombet <[email protected]> wrote: > Review needed, please. > > Thanks, > > Quentin > > On Oct 26, 2012, at 10:48 PM, Quentin Colombet <[email protected]> wrote: > >> Hi, >> >> You will find enclosed a patch to use the forcesizeopt attribute (the >> attribute that tells the compiler to optimize the related functions for size >> first) directly as a source code attribute. >> Previously it was set on each function with the -Oz optimization level. >> >> Quentin >> <ForceSizeOptFE.patch>_______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
