On Fri, Oct 26, 2012 at 5:37 PM, Eli Friedman <[email protected]>wrote:
> On Fri, Oct 26, 2012 at 5:20 PM, Richard Trieu <[email protected]> wrote: > > -Wbool-compare-tautological > > Comparisons involving a boolean and an expression evaluating to 1, 0, > true, > > or false such that the comparison always evaluate to true or false. > > Also added to -Wtautological-compare group > > High true positive rate. > > Not previously caught by -Wtautological-compare > > Please just fix DiagnoseOutOfRangeComparison to do the right thing. > > > -Wbool-compare-tautological-out-of-range > > Comparisons of a boolean and >1 or negative values. > > Also added to -Wtautological-constant-out-of-range-compare group > > High true positive rate. > > Previously, only compares with values >1 were caught. > > (x == 5) currently caught > > (x == -1) not currently caught > > Same. > > -Eli > What do you think of the idea of separating out warnings on bool comparisons into a sub group?
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
