On Mon, Oct 29, 2012 at 5:53 PM, Eli Friedman <[email protected]> wrote: > Per subject, remove -Wdisabled-macro-expansion. It's triggering on > normal uses of stdbool.h in C++ (at least, however normal it is to use > stdbool.h in C++). Because we're trying to encourage people to use > -Weverything,
I share Chandler's concerns about this. Why are you doing that? In my experience, -Weverything is a great tool for "I just found a bug, could you have told me about it?" but not for much else (from an end-user's perspective). We have plenty of warnings which simply don't make sense for a lot of people (for instance, almost any use of any C++11 feature will generate some kind of warning), and it's not reasonable to remove them just to make -Weverything more user-friendly. > it isn't acceptable for it to trigger warnings for usage > of headers included with the compiler, and as far as I can tell, there > isn't any way to fix the header. (See patch for a testcase that > checks we don't trigger any warnings from stdbool.h.) > > I'm planning to commit this unless someone has an alternative suggestion. Could you suppress the warning if the spelling location for the token which would have been expanded is in a system header? _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
