----- Original Message ----- > From: "Ulrich Weigand" <[email protected]> > To: "Hal Finkel" <[email protected]> > Cc: [email protected] > Sent: Wednesday, October 31, 2012 12:56:27 PM > Subject: Re: [cfe-commits] [PATCH] Add missing "static" to altivec.h > > Hal Finkel <[email protected]> wrote on 31.10.2012 17:33:57: > > > The change looks good. Should we add a testcase? > > Ah, good point. Like this?
Yep, that should work. As nbjoerg points out on IRC, these functions should probably have __always_inline__ also. If you look at xmmintrin.h, all of the functions look like this: static __inline__ __m128 __attribute__((__always_inline__, __nodebug__)) _mm_div_ss(__m128 a, __m128 b) ... We should probably do that same. -Hal > > Thanks, > Ulrich > > (See attached file: diff-clang-altivec) -- Hal Finkel Postdoctoral Appointee Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
