LGTM with the default cpu test
================
Comment at: lib/Driver/Tools.cpp:1091
@@ -1090,2 +1090,3 @@
ArgStringList &CmdArgs) const {
+ const bool isAndroid = getToolChain().getTriple().getEnvironment() ==
llvm::Triple::Android;
if (!Args.hasFlag(options::OPT_mred_zone,
----------------
80 chars
================
Comment at: lib/Driver/Tools.cpp:5835
@@ -5833,4 +5834,3 @@
CmdArgs.push_back("-shared");
- if ((ToolChain.getArch() == llvm::Triple::arm
- || ToolChain.getArch() == llvm::Triple::thumb) && isAndroid) {
+ if (isAndroid) {
CmdArgs.push_back("-Bsymbolic");
----------------
Yes, -Bsymbolic is definitely not ARM-specific, but rather Android-specific.
http://llvm-reviews.chandlerc.com/D91
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits