On Nov 1, 2012, at 3:59 PM, Matt Beaumont-Gay <[email protected]> wrote:
> On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi <[email protected]> wrote: >> 2012/11/2 jahanian <[email protected]>: >>> >>> On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay <[email protected]> wrote: >>> >>>> Author: matthewbg >>>> Date: Thu Nov 1 15:26:42 2012 >>>> New Revision: 167249 >>>> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=167249&view=rev >>>> Log: >>>> Silence -Wformat on platforms where uint64_t is unsigned long. >>> >>> Thank you. >>> - Fariborz >>> >>>> >>>> Modified: >>>> cfe/trunk/lib/CodeGen/CGObjCMac.cpp >>>> >>>> Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp >>>> URL: >>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=167249&r1=167248&r2=167249&view=diff >>>> ============================================================================== >>>> --- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original) >>>> +++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Thu Nov 1 15:26:42 2012 >>>> @@ -2353,7 +2353,7 @@ >>>> // Block variable layout instruction has been inlined. >>>> if (CGM.getLangOpts().ObjCGCBitmapPrint) { >>>> printf("\n Inline instruction for block variable layout: "); >>>> - printf("0x0%llx\n", Result); >>>> + printf("0x0%llx\n", (unsigned long long)Result); >> >> PRIx64 may be preferred rather than casting for uint64_t. > > I personally dislike the PRI* macros, but if the community consensus > is otherwise, that's fine :) I personally prefer the explicit type cast; instead of chasing down what PRIx64 is. But... - fariborz _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
